openBVE 1.5.0 RC1 - BUGS

That would be this file, then:
https://dl.dropboxusercontent.com/u/8742935/openBVE%20Bug%20Report12_09_2016.zip

Interesting little crash.

It's crashing in the function which I added to automatically keep track of the contents of the train directory as it seems to think that there's nothing there, but this should never happen.
Added an explicit sanity check to the function, which will hopefully get around this-

Please try the latest nightly.
http://vps.bvecornwall.co.uk/OpenBVE/Builds/OpenBVE-2016-09-14.tar.gz

Note: Not pushing this build to RC status quite yet, as it makes a bunch of changes to improve BVE2 & BVE4 compatibility, which I haven't tested as much as I'd like.

I'm glad it was interesting at least!! - Not just me doing something ****ish"
Yes, that tarball worked fine, no probs picking non-default train.

Chris, the name of controls is still in English in this build instead of the localized key names. (I've emailed you about this before.)

I have sometimes been getting a problem with routes that uses Runinterval in that the train is derailed somewhere along the route. This has happened using 1.5.0.6 and the latest nightly build. I only discover this when I get restrictive signals that don't clear often a fair way from the start. I have been getting this on various routes. I also got this today using your updated Plymouth route with the front of the train derailed just after Dockyard.

I can't think of anything I've done recently which could cause that, but I'll take a dig.

Are you running at very low (or high) FPS?
The only thing I can think of, is that we discovered that the physics engine sometimes reacts badly to very low or high frame times, but I *thought* all of those bugs had been caught now....

phontanka wrote:Chris, the name of controls is still in English in this build instead of the localized key names. (I've emailed you about this before.)

Sorry, that's on my list of things to attack.

It's a little more difficult than it sounds due to an openTK bug/ oddity, which means that (as I think you've found....), it interprets any given key as it's equivalent position on a US/ GB English keyboard, rather than returning the value directly.

If I'm reading your Hungarian translation right, this means that if you connect a US keyboard to a machine using the HU language, the controls will then be 'wrong' in certain places....

The derailing having been happening for a while. I am not sure when this started but it was after you release the first of the 1.5.0 releases. It only happens sometimes and takes some time before it happens again especially at times when I too busy working on my route to discover this issue.

As far as I can remember it has happened on your route and my route (which at the start in the cab I get around 35-45fps) and some others. On your route at the start of the route I get around 35fps and this with integrated graphics. That probably doesn't help as when I use the dedicated graphics on the same machine I get around 60 fps.

The controls should be OK, it's just that the buttons reflect different characters on a Hungarian keyboard and users have no idea where certain characters are on an English keyboard so they have a hard time making changes to the control settings.

Using your Plymouth route the Runinterval train derailed but this took many times of loading the route to happen. When this happened I jumped stations as soon the route was loaded and saw it toppling over. The HST train was used on the 1980's era 104 stopping run when this happened.

sir Chris Lees
I did find these words encouraging from Italy of the sir Luigi Cartello on your new version program of openBVE
http://lnx.trenomania.it/forum/viewtopic.php?f=25&t=125&p=21444#p21444

Good day and night for you
Hijau

YES!

The version coming with http://vps.bvecornwall.co.uk/OpenBVE/Builds/OpenBVE-2016-09-14.tar.gz (OpenBve.exe 1.118.208 byte - date 2016-09-14 14:03) is the first one tested by me not crashing italian routes like Biella-Oropa and Genova-Casella (routes running fine with 1.4.3 version from Odakyufan).

Thank you Chris and my best wishes!

tof63 wrote:YES!

The version coming with http://vps.bvecornwall.co.uk/OpenBVE/Builds/OpenBVE-2016-09-14.tar.gz (OpenBve.exe 1.118.208 byte - date 2016-09-14 14:03) is the first one tested by me not crashing italian routes like Biella-Oropa and Genova-Casella (routes running fine with 1.4.3 version from Odakyufan).

Thank you Chris and my best wishes!

Thanks Luigi

I'll take a look with Biella-Oropa & Genova-Casella, as they're not in my current test set, and I'd like to make sure I haven't just hidden whatever problem you were experiencing previously.

Edit:
Looking at the crash log you've posted at Trenomania, this is what was fixed on Sept 14th.
Since you're the second person to have seen this (Predictably the original works fine at this end), I'll push RC7 now.

I need to fix Phontanka's translation issue, and then I'll see about pushing RC7 to the site.
Phontanka- Your translation issue is on my urgent list, will get to it ASAP.

Matt-
It's very hard to fix what I can't reproduce
I'll try adding some specific logging whenever a train derails, and hopefully that might get us a little closer to finding the root cause of this. It's probably FPS related, but there are all manner of places it could go wrong.

That's fine, Chris.

About my previous crashes with Italian routes, I suppose that something could be wrong with the installer and the Italian version of Windows 7 64bit, because I've discovered that, after the installation of the file openBVE-1.5.0.6-setup.exe, copying the content of the folder c:\Program Files (x86)\openBVE in another folder and launching openBVE from there, everything is fine.

Probably the cause of the first version tested working fine was the format of the distribution package (tar.gz instead of exe installer).

I have Windows installed on a 120 GB SSD and several differents versions of openBVE and a lot of addons on another bigger disk, so the crash happens when I try to open a route file being on the other disk using the link to the file openBVE.exe being in the folder c:\Program Files (x86)\openBVE.

This is the content of one of the OpenBVE Crash logs being in the folder c:\Users\"username"\AppData\Roaming\openBVE\Settings:

Code:

25/09/2016 22:41:54
OpenBVE 1.5.0.6 Crash Log
Program is running on the Windows backend
Current screen resolution is: Windowed 960px x 600px
Current routefile is: E:\OpenBVE\OpenBVE1.4.3\UserData\LegacyContent\Railway\Route\Tr_3_A9_v2.csv
Current train is: E:\OpenBVE\OpenBVE1.4.3\UserData\LegacyContent\Train\A9-OpenBVE
Current train plugin is: OpenBveAts.dll
Current track position is: 61.19 m
Current viewing distance is: 600
The exception caught was as follows:
System.ArgumentOutOfRangeException: InvalidArgument=Value of '0' is not valid for 'index'.
Parameter name: index
   at System.Windows.Forms.ListView.ColumnHeaderCollection.get_Item(Int32 index)
   at OpenBve.formMain.onRouteFolderChanged(Object sender, EventArgs e)
   at System.IO.FileSystemWatcher.OnChanged(FileSystemEventArgs e)
   at System.IO.FileSystemWatcher.NotifyFileSystemEventArgs(Int32 action, String name)
   at System.IO.FileSystemWatcher.CompletionStatusChanged(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* overlappedPointer)
   at System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* pOVERLAP)
Current program memory usage: 204,06mb
System memory free: 5088mb


Translated keys should now work in the current nightly build.

I've also changed the main form, so that the joystick grab box now works for keys too

The occasional loading freeze on Linux has also now been found and squashed, so assuming this works OK for Phontanka etc. , the intention is to push this as RC8.


Cheers

Here are a few bugs I've found that I haven't seen on here yet:

Hitting escape to open the menu and pressing it again gives an error, "Index was outside the bounds of the array" and force closes to the main menu.

Trying to load your Plymouth route with the 81xx as the default train causes the menu to get stuck in an endless loading loop. From my experience, this is the only route that causes this. Not sure if its because i have both the 2d and 3d cab installed.

Interestingly, some control translations don't show up in the 2016-10-03 build. This happens when the control name is a word, not just a letter or a letter+number combnination. Eg "Vessző" (Comma) isn't shown, neither is "Pont" (Period), but A, F5, etc work. In English USA setting all controls work. Of course all controls work while playing.

buckysam wrote:Here are a few bugs I've found that I haven't seen on here yet:

Hitting escape to open the menu and pressing it again gives an error, "Index was outside the bounds of the array" and force closes to the main menu.

Trying to load your Plymouth route with the 81xx as the default train causes the menu to get stuck in an endless loading loop. From my experience, this is the only route that causes this. Not sure if its because i have both the 2d and 3d cab installed.

Found the 81xx issue myself yesterday, that should be fixed in the most recent nightly.

TLDR:
The folder exists & contains subfolders, but isn't a train. This then causes an infinite recursion loop, as it traverses down the subfolders and comes back up again.

I can't reproduce the menu issue:
Please can you try it again and let me have the crash log

phontanka wrote:Interestingly, some control translations don't show up in the 2016-10-03 build. This happens when the control name is a word, not just a letter or a letter+number combnination. Eg "Vessző" (Comma) isn't shown, neither is "Pont" (Period), but A, F5, etc work. In English USA setting all controls work. Of course all controls work while playing.

Can see this, investigating.
If you open the dropdown list, Vessző is there, so it looks like it's just not updating the index right. Probably something simple.....

Fixed for the current nightly.

I confirm, "Vessző", "Pont", etc show up correctly in the 2016-10-04 build.

leezer3 wrote:

buckysam wrote:Hitting escape to open the menu and pressing it again gives an error, "Index was outside the bounds of the array" and force closes to the main menu.

I can't reproduce the menu issue:
Please can you try it again and let me have the crash log

After loading into the sim, when you press escape to open the menu with says resume, jump to station, etc. If you press escape to exit the menu, like you could before, it throws the error, "The route and train loader encountered the following critical error: Index was outside the bounds of the array." and closes to the main menu.
As for the crash log, it gives this:

Code:

10/6/2016 10:03:33 AM
OpenBVE 1.5.0.7 Crash Log
Program is running on the Windows backend
Current screen resolution is: Windowed 960px X 600px
Current routefile is: C:\Users\Samuel\AppData\Roaming\openBVE\LegacyContent\Railway\Route\Birmingham_Cross-City_South_openBVE\Dawn\323_Summer_2002_0625_Clear.csv
Current train is: C:\Users\Samuel\AppData\Roaming\openBVE\LegacyContent\Train\Cl323 Unrefurb_openbve
Current train plugin is: UkTrainSys.dll
1 error(s)
The current routefile caused the following exception:
Index was outside the bounds of the array.
Current program memory usage: 136.28mb
System memory free: 4060mb


It says the same thing.

Hmm, still works perfectly here

All that really tells me is that *something* somewhere is crashing in a background thread triggered by the loader, which is unfortunately not the details I was hoping for
These should all have terminated, so I'm at a loss.

Have you moved any controls or done anything other than just pressing ESC twice?

Edit:
Have added some more stuff to both logging and the crash log for today's build.
Can you try again and let me have both the main log and the crash log?

Would also like to know whether the train affects this at all.
I'll get to the bottom of this eventually, just need to figure out where it's gone wrong......

Cheers

Please try this build, I think I might have got to the bottom of it, although I've only managed to reproduce once in about 100 attempts this afternoon:
http://vps.bvecornwall.co.uk/OpenBVE/Builds/OpenBVE-2016-10-06.tar.gz

Tried again with the new build using 4 different trains and routes and it happened every time, keeps throwing the same error. Crash log still reads the same. It happens regardless of the train or route. I also double-checked folder permissions in case it had something to do with it, but i have full control of everything, so that's not it. Here's the last crash log anyway:

Code:

10/6/2016 7:57:34 PM
OpenBVE 1.4.252.1059-travis Crash Log
Program is running on the Windows backend
Current screen resolution is: Windowed 960px X 600px
Current routefile is: C:\Users\Samuel\AppData\Roaming\openBVE\LegacyContent\Railway\Route\Chashinai Railway\Ishinden Line\Daytime - Express train 1.csv
Current train is: C:\Users\Samuel\AppData\Roaming\openBVE\LegacyContent\Train\Chashinai Railway\5000 Series\4 cars
Current train plugin is: OdakyufanAts.dll
The current routefile caused the following exception:
Index was outside the bounds of the array.
Current program memory usage: 156.89mb
System memory free: 4152mb


Still can't reproduce anything

Have tried with both Chasanai and Birmingham X-City, both stored in my usual BVE directory and in the AppData directory.

I've tried with the following machines:
* Win 7 x64 laptop.
* Win 8 x64 desktop.
* Ubuntu VM
* Mac OS El Capitan VM.

I've made one more change to today's build (Not at all convinced it'll help, but I can't easily fix what I can't reproduce.....)

No idea why the stack traces are missing from the crash logs, but something's funky....
If it still crashes, can I have the simulation log itself please?

I've added a few more bits to it, and for that matter it would also be interesting to see if the sim thinks there were any errors at all.
http://vps.bvecornwall.co.uk/OpenBVE/Builds/OpenBVE-2016-10-07.tar.gz