BVE WorldWide
Would you like to react to this message? Create an account in a few clicks or log in to continue.

XML NotchDescriptions crash Openbve on loading

2 posters

Go down

XML NotchDescriptions crash Openbve on loading Empty XML NotchDescriptions crash Openbve on loading

Post by Delsin Fri Nov 10, 2023 1:26 pm

Using NotchDescriptions causes crash on startup, Openbve reverts to main menu when attempting to load a train using this. Happens on stable 1.9.2.2.

Also, loco brake interface label is blank on all trains fitted with it
Delsin
Delsin

Posts : 313
Join date : 2016-08-20

Back to top Go down

XML NotchDescriptions crash Openbve on loading Empty Re: XML NotchDescriptions crash Openbve on loading

Post by leezer3 Tue Nov 14, 2023 8:09 pm

I can't reproduce this on 1.9.2.4, everything appears OK to me for both of your issues above.

My immediate suspicion would be malformed XML (duplicate properties?) somewhere which we aren't handling nicely.
Sample please?

XML files only is fine.

leezer3

Posts : 1960
Join date : 2011-08-23

http://www.bvecornwall.co.uk

Back to top Go down

XML NotchDescriptions crash Openbve on loading Empty Re: XML NotchDescriptions crash Openbve on loading

Post by Delsin Thu Nov 16, 2023 12:19 am

https://cdn.discordapp.com/attachments/1172533635115663360/1172534016461787237/TKK9000.rar (same train as attached on github for sound testing, please uncomment NotchDescriptions in Train.xml)
Delsin
Delsin

Posts : 313
Join date : 2016-08-20

Back to top Go down

XML NotchDescriptions crash Openbve on loading Empty Re: XML NotchDescriptions crash Openbve on loading

Post by leezer3 Thu Nov 16, 2023 12:28 pm

It's malformed XML.
Code:
<Reverser>切,前,後/Reverser>

You're missing the closing < for the reverser.
(Try using an editor which highlights XML such as Notepad++)

Fixing that makes the thing work- All descriptions appear for me correctly.

I've made a couple of changes as a result of this which will help, but a malformed XML can't be loaded. 
(This was one of the major points of choosing XML- The csv / dat formats do some interesting and unxepected things sometimes when malformed, which simply aren't possible with XML)

leezer3

Posts : 1960
Join date : 2011-08-23

http://www.bvecornwall.co.uk

Back to top Go down

XML NotchDescriptions crash Openbve on loading Empty Re: XML NotchDescriptions crash Openbve on loading

Post by Delsin Thu Nov 16, 2023 7:53 pm

That explains it Laughing double-checked the syntax but still missed it.
I do use Notepad++, but it didn't help apparently.

Makes me think it needs some sort of better error feedback than just crashing tho...
Delsin
Delsin

Posts : 313
Join date : 2016-08-20

Back to top Go down

XML NotchDescriptions crash Openbve on loading Empty Re: XML NotchDescriptions crash Openbve on loading

Post by leezer3 Fri Nov 17, 2023 12:54 pm

That's what the changes from yesterday were- Stops the crash and tweaks a couple of related bits, but it physically can't load a malformed XML.

leezer3

Posts : 1960
Join date : 2011-08-23

http://www.bvecornwall.co.uk

Back to top Go down

XML NotchDescriptions crash Openbve on loading Empty Re: XML NotchDescriptions crash Openbve on loading

Post by Sponsored content


Sponsored content


Back to top Go down

Back to top

- Similar topics

 
Permissions in this forum:
You cannot reply to topics in this forum