Incorrect plugin behavior? (all Openbve versions)
2 posters
Page 1 of 1
Incorrect plugin behavior? (all Openbve versions)
So I've known of this for years since it's been in every Openbve build I've tried, but only now realized it might be a bug in how it handles plugin functions.
Some Japanese trains (mostly those in Tokyo Metro and nearby) have a built-in departure sound similar to station melodies with the same purpose, while on it plays a buzzer/looped music bit, once off it runs a "doors closing" announcement once or twice. In BVE this is often reproduced with a Metro plugin - buzzer is set as music horn and the plugin plays the announcement on every 2nd music horn key activation (= when the looped sound is turned off), however, in Openbve it triggers on secondary horn instead.
Train examples: https://cdn.discordapp.com/attachments/707013713500045334/707030786116681798/trta.zip
(use 7000 series only, 6000 is incomplete and 9000 uses a different plugin)
Plugin page: http://nozomi.vc/71_ats/index.htm
Some Japanese trains (mostly those in Tokyo Metro and nearby) have a built-in departure sound similar to station melodies with the same purpose, while on it plays a buzzer/looped music bit, once off it runs a "doors closing" announcement once or twice. In BVE this is often reproduced with a Metro plugin - buzzer is set as music horn and the plugin plays the announcement on every 2nd music horn key activation (= when the looped sound is turned off), however, in Openbve it triggers on secondary horn instead.
Train examples: https://cdn.discordapp.com/attachments/707013713500045334/707030786116681798/trta.zip
(use 7000 series only, 6000 is incomplete and 9000 uses a different plugin)
Plugin page: http://nozomi.vc/71_ats/index.htm
Delsin- Posts : 313
Join date : 2016-08-20
Re: Incorrect plugin behavior? (all Openbve versions)
When the horn is played, we call the legacy plugin HornBlow interface here:
https://github.com/leezer3/OpenBVE/blob/master/source/OpenBVE/System/Plugins/LegacyPlugin.cs#L379
As this takes a raw integer as a parameter, we cast the 'friendly' enum API horn type.
https://github.com/leezer3/OpenBVE/blob/master/source/OpenBveApi/Runtime/Train/HornTypes.cs
Here, the horns are numbered:
0 - Primary
1 - Secondary
2 - Music
This matches Mackoy's ATSPlugin spec file here:
http://bvets.net/old/make4/atsplugin.h
I've run through this in the debugger, and it's definitely working to spec.
I could do with some more specific English driving instructions & / or a correctly setup route to see what the plugin is doing though.
Loaded this on the Odaykufan ATC test route.
Hit 8 to insert the master key.
The instructions seem to suggest it should work from there as per a normal train.
I've also tried all 3 modes on the second switch & pressing DEL to reset the chime (Was assuming ATC from there would work) but nothing.
It doesn't trigger the looped bit you're talking about either, but presumably it needs the cab setup for that.
I don't *think* this is an OpenBVE bug at the minute.
https://github.com/leezer3/OpenBVE/blob/master/source/OpenBVE/System/Plugins/LegacyPlugin.cs#L379
As this takes a raw integer as a parameter, we cast the 'friendly' enum API horn type.
https://github.com/leezer3/OpenBVE/blob/master/source/OpenBveApi/Runtime/Train/HornTypes.cs
Here, the horns are numbered:
0 - Primary
1 - Secondary
2 - Music
This matches Mackoy's ATSPlugin spec file here:
http://bvets.net/old/make4/atsplugin.h
I've run through this in the debugger, and it's definitely working to spec.
I could do with some more specific English driving instructions & / or a correctly setup route to see what the plugin is doing though.
Loaded this on the Odaykufan ATC test route.
Hit 8 to insert the master key.
The instructions seem to suggest it should work from there as per a normal train.
I've also tried all 3 modes on the second switch & pressing DEL to reset the chime (Was assuming ATC from there would work) but nothing.
It doesn't trigger the looped bit you're talking about either, but presumably it needs the cab setup for that.
I don't *think* this is an OpenBVE bug at the minute.
Re: Incorrect plugin behavior? (all Openbve versions)
It's different from Odakyufan's stuff, it uses its own ATC system.
Try this route and train, they use the same plugin.
https://web.archive.org/web/20130217091503/http://shtr-m.net/bve/data/ginza2_11.zip
https://web.archive.org/web/20130217091350/http://shtr-m.net/bve/data/trta01_ver2_11.zip
Startup: ensure the handle is in Emergency and reverser is in Neutral, press 8 to turn on the key and you should be able to drive.
The buzzer thing activates in the same way (music horn)
Try this route and train, they use the same plugin.
https://web.archive.org/web/20130217091503/http://shtr-m.net/bve/data/ginza2_11.zip
https://web.archive.org/web/20130217091350/http://shtr-m.net/bve/data/trta01_ver2_11.zip
Startup: ensure the handle is in Emergency and reverser is in Neutral, press 8 to turn on the key and you should be able to drive.
The buzzer thing activates in the same way (music horn)
Delsin- Posts : 313
Join date : 2016-08-20
Similar topics
» Help me fix this openbve plugin for blender
» HK OpenBVE Seltrac Plugin Issues
» Incorrect brightness behavior on train objects
» Wrong darkness behavior in BVE4 panel2.cfg cabs
» Inconsistent PowerNotchReduceSteps behavior
» HK OpenBVE Seltrac Plugin Issues
» Incorrect brightness behavior on train objects
» Wrong darkness behavior in BVE4 panel2.cfg cabs
» Inconsistent PowerNotchReduceSteps behavior
Page 1 of 1
Permissions in this forum:
You cannot reply to topics in this forum
|
|