Incorrect brightness behavior on train objects

Took me a while to notice, now I finally caught it. On many versions, including the latest build, when some trains with cars are made of multiple objects pass a brightness change, it won't change simultaneously on all objects of the car and there will be a delay on some of them. Here are car objects I've noticed this on: https://cdn.discordapp.com/attachments/707013713500045334/766359621848793148/test.rar

Yesterday I did a full reinstall of the game and now I'm getting the exact same issues, and before i reinstalled it didn't happen

Hmm..
The linked file isn't a complete train & doesn't really tell me much.

Immediate thought though:
I suspect the problem objects are most likely bogies.
IIRC the cars exterior brightness is being derived from the front axle track position.
The bogie is probably pulling its brightness from its own axle, not the cars. This would likely cause the issue  although it could also be seen as 'better too, depending on how the train is constructed.

Will have a think and look next week.

No, the issue is in the car objects themselves since they're made of multiple b3d files made to fit each other. Look at doors and windows outside as the train goes thru brightness changes.

Complete train: https://www.dropbox.com/s/wneff7pww8fe6vo/E20.rar?dl=0

I can see the problem.

https://github.com/leezer3/OpenBVE/blob/master/source/OpenBVE/Simulation/TrainManager/Car/Car.cs#L712

The daytime / nighttime blend is being stored in the base shared model mesh, as opposed to the instance. This wasn't a problem when we weren't caching objects, but it's now incorrect.

Will need a minor redesign somehow.

Easier than I thought:
https://vps.bvecornwall.co.uk/OpenBVE/Builds/OpenBVE-2021-01-27.zip

Will hopefully fix that.

Thanks, that has fixed the problem

Good

As a warning, things may break tempoarily in daily builds over the next week or so.
I'm currently working on separating the TrainManager into it's own assembly and trying to restructure some bits and bobs.

(This is basically in preparation for moving train loading into plugins as per the routes)

Lol obviously development builds are minefields somewhat

Think I found something else with train objects. Reversed = True seems to do something weird with animated objects at times, but this one happens somewhat inconistently, only on select 1-2 cars within some trains, need to pinpoint when exactly it happens. Will make a topic once I catch it properly.

Also I got a discord server with a few other Openbve content developers, can give a link if you're interested. Can make bug reporting and any feedback in general faster since I don't visit the forum very often

If that's what I think it is, it currently matches the behaviour of 1.4.3 (Try the 81xx or anything with a combination of Y & Z rotation and movement)