A tool to fix daytime/nighttime texture related lighting issues

After a discussion with @LXQt, I made a tool to automatically fix the problem raised by the recent change in lighting behaviour with the same texture defined for both daytime and nighttime. (https://github.com/leezer3/OpenBVE/wiki/Errata#lighting-behaviour-with-the-same-texture-defined-for-both-daytime-and-nighttime)
This tool can batch-process CSV and B3D models, while detecting and patching this issue by automatically removing duplicate textures and introducing emissive color commands.

This tool can certainly help developers adapt their models to the new standard, because manually modifying all the models is time-consuming, but it can be done fully automatically with this tool.
Since it is a third-party tool that assists in fixing the problem, I would personally recommend listing this tool on the Errata wiki page.

The tool can be downloaded at https://www.zbx1425.tk/nautilus/daynightfix.html.

Linked from the errata note.

I'd appreciate it if you also added a brief English description to your page as it's all in Chinese at the minute

leezer3 wrote:Linked from the errata note.

I'd appreciate it if you also added a brief English description to your page as it's all in Chinese at the minute

Will do that later. Thanks!

I think it's a great tool.

Howerver, this issue is not limited to specifying the same thing.
This issue occurs even when different textures are specified for Daytime and Nighttime.
https://github.com/leezer3/OpenBVE/issues/490
https://github.com/leezer3/OpenBVE/issues/480#issuecomment-627630431

The errata text should be corrected.

The text was right, the title wasn't, now corrected.

Thanks!

leezer3 wrote:The text was right, the title wasn't, now corrected.

So if I understood it correctly, to get the lighting working in the same (buggy) way as before, pure white EmmisiveColor has to be applied not only to faces with the same day/night texture, but actually all faces that used a nighttime texture.

So, to achieve the same legacy effect, the following code

Code:

......
LoadTexture, day.png, night.png


should be changed into

Code:

......
SetEmissiveColor, 255, 255, 255
LoadTexture, day.png, night.png

instead of preserved as-is. Is that the case?

Also, to achieve the same legacy effect, should the following code

Code:

......
LoadTexture, day.png, day.png

be changed into

Code:

......
SetEmissiveColor, 255, 255, 255
LoadTexture, day.png

or

Code:

......
SetEmissiveColor, 255, 255, 255
LoadTexture, day.png, day.png

?

Correct.

We originally thought it was *just* identical textures (which were the vast majority of the observed effect), but it's actually all

leezer3 wrote:Correct.

We originally thought it was *just* identical textures (which were the vast majority of the observed effect), but it's actually all

Thanks!

As for the second question, is there a visible difference between them?

Code:

SetEmissiveColor, 255, 255, 255
LoadTexture, day.png

SetEmissiveColor, 255, 255, 255
LoadTexture, day.png, day.png

If there is, which one represents the legacy behavior better?

No difference.