**ALPHA** OS_ATS in C#

Source for v0.13 on Github:
https://github.com/leezer3/bvec_ats

Not optimized at the moment, and there are still some bits that are hangovers from the initial modified components.
Should be pretty well commented, although I haven't really got as far as assigning descriptors to all the parameters.

Licence is BSD 2-clause-
Whilst in some ways public domain is 'better', BSD seems to comply better with the original OS_ATS license intent.

This should compile with either Visual Studio or SharpDevelop.

Cheers

Chris Lees

http://www.bvecornwall.co.uk

I meant to say this earlier, but I'll say it now.

Good job Chris! I really like where this is going. This will add so many new functions and features to openbve. I really looking forward to seeing the new trains people will make that will benefit greatly from your new plugin. Not to mention, we'll finally be able to simulate real steam trains in openbve, which I have to say will certainly be a great milestone in bve history. 

Version 0.14
Changes:

• Implemented horn (klaxon) indicators. Slight change from OS_ATS; klaxonindicator now accepts upto 6 parameters as follows:
  

1. Panel index for primary horn indicator
   
2. Display time for primary horn indicator (in milliseconds, default 500)
   
3. Panel index for secondary horn indicator
   
4. (New) Display time for secondary horn indicator (in milliseconds, default 500)
   
5. (New) Panel index for music horn indicator
   
6. (New) Display time for music horn indicator (in milliseconds, default 500)
   

• New variable for steam: klaxonpressureuse This sets the number of additional pressure units per second decrease whilst any horn is active (Uses the timings above)
  

(Internal- Set git to ignore the binaries)

Cheers

Chris Lees

http://www.bvecornwall.co.uk

Version 0.15
Changes:

• 5 custom indicators implemented, using keys 2,3,4,5 & 6. The customindicators value has been changed to a comma separated list of panel indicies. (Will be automatically upgraded from existing trains as per the rest)
  
• Various fixes for bugs introduced by me.
  
• Automatic cutoff/ gears key moved to DEL
  

This version should now be feature comparable with OS_ATS, other than the non-implementation of the basic LU type trainstop. The primary remaining issue is that less custom indicators are available, as the keys aren't currently re-assignable within the plugin [Only within the OpenBVE settings] 
What this needs now is people to try driving it, and see what happens. I've tested with these trains:

• BVETMD Class 104 DMUs [One custom indicator short, otherwise works as designed]
  
• GWR 81xx
  
• HS_6036 Italian steam loco
  
• 1992 Tube stock
  
• 1995 Tube stock
  

All of these appear to work reasonably well, although I've by no means tested extensively. Just about anything that uses an unmodified version of OS_ATS should be *theoretically* supported, but I make no warranties implied or otherwise.
If OpenBVE crashes, please let me know the train, route and approximately where you were/ what you were doing.

Known unsupported trains:

• F-92 U-Bahn (Customized version of OS_ATS)
  
• DB 1938 Diesel Hydralics (Customised version of OS_ATS)
  

Key assignments:

1. S [Space]- DRA appliance
   
2. A1 [Insert]- Reset/ acknowledge security systems. (AWS, TPWS, vigilance)
   
3. A2 [Delete]- Toggle automatic cutoff/ gears
   
4. B1 [Home]- Gear up
   
5. B2 [End]- Gear down/ toggle steam injector
   
6. C1 [PgUp]- Cutoff up
   
7. C2 [PgDn]- Cutoff down
   
8. D - H [2- 6]- Custom indicators
   
9. I [7]- Fill fuel/ reset ACB/ VCB
   
10. J [8]- Wiper speed up
    
11. K [9]- Wiper speed down
    
12. L [0]- Isolate (override) safety systems if permitted
    

These will be different to those provided in your loco's manual/ on the on-screen display, this can't be helped at present.

Cheers

Chris Lees

http://www.bvecornwall.co.uk

Version 0.151
Changes:

• Merged all keypress events into the tractionmanager class. [Internal change; I'm thinking about re-assignable keys, for which this is the first step]
  
• More bugs.....
  

I seem to be introducing more bugs every time I do something   
I *think* this version is now bug-free, but I make no guarantees on that.

Cheers

Chris Lees

http://www.bvecornwall.co.uk

Version 0.152
Changes:

• Couple of tweaks/ fixes in the revving at neutral function.
  

Trying again for bug-free status  

Cheers

Chris Lees

http://www.bvecornwall.co.uk

Version 0.16
Changes:

• Fixed a crash with diesel traction rolling backwards down a hill in neutral.
  
• Possible number of custom indicators increased to 10.
  

• Key assignments may be changed using the [KeyAssignments] section. Possible parameters are as follows:
  

1. safetykey
   
2. automatickey
   
3. gearupkey
   
4. geardownkey
   
5. cutoffupkey
   
6. cutoffdownkey
   
7. injectorkey
   
8. wiperspeedup
   
9. wiperspeeddown
   
10. isolatesafetykey
    
11. customindicatorkey1 ==> customindicatorkey10
    

The data for these should represent one of the security keys [A1 ==> L], and *must* be in capitals.

The default key assignments are as per the version 0.15 post

Cheers

Chris Lees

http://www.bvecornwall.co.uk

Dexter wrote:

I am wondering about this... I would probably need to rewrite the cfg file if I wanted to transfer my engines from Oskari's plugin, right?

Nope
Just extract into the train folder and it will generate a replacement cfg file from the original OS_ATS1.cfg
Basically all the parameters are identical (Deliberately), and those that aren't, the plugin will alter to suit.

Mind-you, you're using the most custom indicators I've found just yet (11), so the last custom indicator won't work without a small tweak on my part.
754-049-5 appears to work relatatively well as designed.

The plugin doesn't upgrade the key assignments *just* yet, but that isn't difficult to do, and I'll do something about that soonish

I've also just noticed these bugs:

• Wetwipe/ drywipe/ drop sounds not currently implemented.
  
• It's possible to trigger the DRA on a train without it fitted.
  

Give me a little while.....

Cheers

Chris Lees

http://www.bvecornwall.co.uk

Version 0.17
Changes:

• No longer possible to activate the DRA on a train it is not fitted to.
  
• Wiper & drop sounds implemented as follows:
  

1. dropsound Two comma separated values, representing the first sound index for windscreen wiper drops, and the total number of sounds. [Identical to OS_ATS]
   
2. drywipesound The sound index played when the wiper moves with less than 20% of the possible raindrops are on the windscreen, *or* when no wetwipe sound is set. [As per OS_ATS]
   
3. wetwipesound The sound index played when the wiper moves with more than 20% of the possible raindrops on the windscreen.
   
4. wipersoundbehaviour If set to 0, the wiper sound only plays when the wiper starts moving from the hold position. Otherwise, it plays when the wiper starts moving from either side of the windscreen.
   

Cheers

Chris Lees

http://www.bvecornwall.co.uk

It downloads at this end, but let me know if you're still having problems and I'll stick it on my server as opposed to attaching here.

Pantograph up/ down status isn't currently implemented, but that can be done without too much trouble. I note you're using a pair of pantographs in the 163-133-7 ; Simulation of being able to raise/ lower and thus have effect on traction current of more than one is doable, but may well end up being a nasty piece of implementation, which frankly I'd rather avoid.....
Would a single pantograph provide all required traction current, or is there some different behaviour?


I've got to go to work very soon, but I'll see if I can't knock up something a little later in the weekend for raising/ lowering a single pantograph at the least.

Cheers

Chris Lees

http://www.bvecornwall.co.uk

Pantograph wise, a single Multiple Unit or Locomotive will usually work on one pantograph even if more then one is fitted, but cannot cross-feed to another separate loco/MU.

If you're thinking of the Woodhead electrics, i think the uise of both pantographs was because of the level of tensioning on the OHL- the EMUs on that line worked fine with just the one panto, and the Bo+Bo locos tested out of Liverpool Street on the Great Eastern only needed on raised.

Also countries running DC lines (also called "doorbell voltage" ) often require both pantographs risen.

OK, so first off, to note, the default configuration of the 163 causes BVEC_ATS v0.17 or below to throw a fit (I'll fix these for the next version)

This is because it doesn't like the fact that you've left a blank space after the comma in gearratios. [It attempts to parse this value and there's no check for an empty value at the minute; I hadn't expected there to be one.....]
It also doesn't like the fact that 11.1 is a double, not the int it was expecting. Change these and at the least it won't crash!

I also need to add an ammeter to diesel trains, as this is missing at present.


On the flip side, I've now integrated pantograph raising or lowering as follows:
There are two pantographs fitted to any given train.
Unless the starting state is set via the route to be on service, then the pantographs will both start in the lowered position, with the ACB/ VCB in the open position.
Pressing the front or rear pantograph toggle, will raise the appropriate pantograph & light the line volts indicator.
A customizable length countdown timer is then started, after the expiry of which the ACB/ VCB may be closed and traction current enabled.

If the ACB/ VCB is closed, and a pantograph is attempted to be raised, then the ACB/ VCB will trip to open.
A customizable length cooldown timer is then started, after which you may attempt to raise the pantograph again.

Pantographs may be lowered at any time


Comments are appreciated on the exact workings of this.
Edit: As a FWIW, I can easily enough add a condition that both pantographs must be raised before traction current is available. Not sure what I should do with the line volts indicators then mind....

Cheers

Chris Lees

http://www.bvecornwall.co.uk

Version 0.18
Changes:

• Various bugs.
  
• Pantographs implemented as follows:
  

1. pantographindicator_f Panel index of the front pantograph indicator (Electric section of the .cfg file)
   
2. pantographindicator_r Panel index of the rear pantograph indicator
   
3. pantographsound Sound index played once when the pantograph is raised
   
4. pantographalarmbehaviour Sets the behaviour when a pantograph is lowered at speed with the ACB/VCB closed: 0 Pantograph lowers (Default) 1 Pantograph lowers and ACB/VCB trips 2 Pantograph lowers, ACB/VCB trips and brakes are applied
   
5. pantographalarmsound Sound index played looped when the pantograph is lowered at speed & brakes are applied
   
6. pantographretryinterval Sets the retry interval in ms for raising the pantograph. [Applies after a pantograph has been lowered at speed & the train braked to a stop *OR* after an attempt to raise a pantograph has been made with the ACB/VCB closed] Default value is 5000ms
   
7. frontpantographkey & rearpantographkey (Keyassignments section of the .cfg file)
   

Cheers

Chris Lees

http://www.bvecornwall.co.uk

I'm guessing your next things on the list to do is to do the Neutral section (phase break) installations which isolates different phases of the power supply being fed to the overhead electrification system from each other.


Anthony has this in his UkTrainsys plugin. http://railsimroutes.net/blog/?p=912


Regards

What's the ACB/VCB? I don't know the abbreviations and also don't seem to recognise the function it is supposed to have.

Quork wrote:What's the ACB/VCB? I don't know the abbreviations and also don't seem to recognise the function it is supposed to have.

Air Circuit Breaker / Vacuum Circuit Breaker (Luftstromschalter / Vakuumbrecher according to dict.cc). It acts as the main breaker (Hauptschalter? my German is awful   ) on the high voltage side between the pantograph and the rest of the locomotive (on AC traction the next component is the main transformer).

Ah okay, thank you! Yes, it's "Hauptschalter" (wth the vacuum one being usually called "Vakuumhauptschalter"). On german vehicles it isn't possible to close it without voltage (erm, 12.0kV < U < 17.5kV IIRC); and if voltage should drop below (or shoot over) the threshold, the main breaker opens automatically. That's why I was irritated by the possibilities in the posts above to (try to) raise the pantograph with closed ACB/VCB or to lower the pantograph without the ACB/VCB tripping and thus didn't recognise it as the main breaker... Are there really vehicles where this is possible?

As far as I know, all electric equipment (locomotives and EMUs) requires the line voltage to be within set limits for the main breaker to close. Also, I'd imagine lowering the pan without opening the main breaker is a Bad Idea™, which is why I suspect it would happen automatically. Otherwise, since there's always some degree of current consumption, the pan would draw an arc from the wire, damaging both the contact strip and the wire. The circuit breaker is designed to contain and extinguish the arc. This is also the reason why there are magnets around neutral sections to automatically open and close the main breaker. 

Even if lowering the pan with the main breaker closed were OK, it would drop the line voltage to zero, opening the main breaker anyway. Therefore the main breaker should never be closed when no pantographs are up.

I think the simulation can get away with opening the main breaker automatically when a) line voltage is outside the set limits, like Quork said, (which are rather generous; for 25 kV something like 19 to 27 kV), or b) a magnet is passed ahead of a neutral section, or c) a separate Open Main Breaker control is operated, of course.

With UkTrainSys.dll the Class 323 closes the main breaker automatically when the pan is raised, and opens when lowered. (And it only has one pantograph per unit.)

Couple of comments on the most recent replies

Neutral sections-
Already implemented. Both the OS_ATS standard and UKTrainsys standard should work.
A theoretically infinite number of defined power pickup points (pantographs/ shoes) are available for simulation of these, which work as per the OS_ATS behaviour.

Main Breaker (ACB/VCB)-
This mostly replicates the UKTrainsys behaviour- The only substantial difference is that the driver needs to manually close it after raising a pantograph, and the adjustable cooldown timers/ behaviour.
The primary reason for this was to allow flexibility on behalf of train developers, and the simulation of much earlier stock for which many of these automatic systems didn't apply. 

Edit:
Version 0.19
Changes:

• Added gearloopsound for diesel traction.
  
• Added gearchangesound to paramaters automatically upgraded. (Oversight, this has always been supported)
  

Cheers

Chris Lees

http://www.bvecornwall.co.uk

leezer3 wrote:Couple of comments on the most recent replies

Neutral sections-
Already implemented. Both the OS_ATS standard and UKTrainsys standard should work.
A theoretically infinite number of defined power pickup points (pantographs/ shoes) are available for simulation of these, which work as per the OS_ATS behaviour.

Main Breaker (ACB/VCB)-
This mostly replicates the UKTrainsys behaviour- The only substantial difference is that the driver needs to manually close it after raising a pantograph, and the adjustable cooldown timers/ behaviour.
The primary reason for this was to allow flexibility on behalf of train developers, and the simulation of much earlier stock for which many of these automatic systems didn't apply. 

Thanks for clearing this up, and thank you for the excellent work!

Right, I have done a bit of experimentation with my 362-165 and here is what I have found.  

This is the config file I have managed to put together (apparently I am not allowed to access the local hard drive and write into the Program Files directory on some PCs, so I had to help it out manually.  

Code:

[Electric]
pantographindicator_f=71
pantographindicator_r=72
Breakerindicator=30

[Interlocks]
reverserindex=191
doorpowerlock=1
doorapplybrake=1
customindicators= 198,61,62,63,64,65,66,30

[Vigilance]
overspeedcontrol=1
warningspeed=124
overspeed=130
safespeed=118
overspeedindicator=60
deadmanshandle=1
vigilancelamp=11
vigilancealarm=0
vigilanceinterval=22000
vigilancecancellable=0
vigilanceautorelease=1

[Windscreen]
wiperindex=199
wiperrate=1000
wiperdelay=3000
wiperholdposition=100
drywipesound=17
wipersoundbehaviour=0
dropstartindex=200
numberofdrops=55
dropstartindex=200
dropsound=250,5

[KeyAssignments]
safetykey=S
frontpantographkey=F
rearpantographkey=G
customindicatorkey1=H
customindicatorkey2=A1
customindicatorkey3=A2
customindicatorkey4=B1
customindicatorkey5=B2
customindicatorkey6=C1
customindicatorkey7=C2
customindicatorkey8=D
wiperspeedup=H
wiperspeeddown=I
fuelkey=D

This setup pretty much gives me what intended, there are a few things worth thinking about, maybe.   

1) If I manage to turn the main breaker on and the pantographs are still down, I will still receive surge values on voltmeters. It surely is the way it is coded (2D cab), but there is no possibility to make it dependent on both pantograph and main breaker being active. Is there any workaround for that?

2) If I have not missed anything out, some of the sounds might still not be supported. I am currently having problems with the following sounds. Especially turning the main breaker on without any sounds is odd.

Code:

[Ats]
0 = Sound\Eb.wav
2 = Sound\Loop.wav
4 = Sound\Oversp.wav
30 = Sound\HvDwn.wav
60 = Sound\Oversp.wav
198 = Sound\WiperCont.wav


Am I doing something wrong, or is that yet to be implemented? I find it strange some other sounds with different ATS indexes are played as usual...

3ú Wipers - the cycler has more than one setting in most engines, which means you need two controls (Cycle up, cycle down). However, assigning a wiper control animation is difficult in 2D cab, as this requires two keys (Cycler+, Cycler-), but you are only allowed one CustomIndicatorKey per plugin (I have noticed that if you put two, the latter one is used). In real life, you rotate 1 control button, but that is not really possible on a keyboard and you have to use 2 keys. Any ideas in that then? :-) I know there is

Code:

wiperspeedup=H
wiperspeeddown=I

but a plugin can only be assigned one custom controlling key. So if the controller is Ats198, the will only turn when using wiperspeedup=H OR wiperspeeddown=I. It won't go forwards and backwards.

Also, the usage of pantographsound is as usual? pantographsound = [index] and then define the index within ATS section of the sound file?

There might be more questions to come from me!  
Thank you ever so much!