BVE WorldWide
Would you like to react to this message? Create an account in a few clicks or log in to continue.

Panel glitches

Go down

Panel glitches Empty Panel glitches

Post by Delsin Thu Oct 15, 2020 7:09 pm

Spotted on Oct 13 build

Edit: Panel2 panels are affected too
Panel glitches Panelb10
Delsin
Delsin

Posts : 283
Join date : 2016-08-20

Back to top Go down

Panel glitches Empty Re: Panel glitches

Post by leezer3 Sat Oct 17, 2020 12:58 am

Terminally stupid question-
What am I looking at, & what train? Razz


Nothing appears immediately out of place, except *possibly* the cover for the speedometer needle, but that could just be the panel?

leezer3

Posts : 1785
Join date : 2011-08-23

http://www.bvecornwall.co.uk

Back to top Go down

Panel glitches Empty Re: Panel glitches

Post by Delsin Sat Oct 17, 2020 3:45 pm

Covers and a few other elements are missing, and needles disappear at times. Some covers reappear when needles move.

Happens on any 2D panel for me, so not sure what specific train to provide for testing.
Delsin
Delsin

Posts : 283
Join date : 2016-08-20

Back to top Go down

Panel glitches Empty Re: Panel glitches

Post by leezer3 Sat Oct 17, 2020 3:55 pm

Yeah, I've found an interesting error in the vector transforms.
It causes the smaller decimal places to be off & rounding errors.

The change that caused this sympton is this:
https://github.com/leezer3/OpenBVE/commit/8a9e0755bad2b617b75a2d07e5bf97c52abd7818

Cause is specifically the last part of the transform here, which shouldn't be there:
https://github.com/leezer3/OpenBVE/blob/master/source/OpenBveApi/Math/Vectors/Vector3.cs#L632
double x = (X * transformMatrix.Row0.X) + (Y * transformMatrix.Row1.X) + (Z * transformMatrix.Row2.X) + (1 * transformMatrix.Row3.X);

What I'm trying to figure out is why this was added in the first place, and whether removing it breaks something else....
(Sure I can just revert the commit, but there may be unspotted other errors)

leezer3

Posts : 1785
Join date : 2011-08-23

http://www.bvecornwall.co.uk

Back to top Go down

Panel glitches Empty Re: Panel glitches

Post by Sponsored content


Sponsored content


Back to top Go down

Back to top


 
Permissions in this forum:
You cannot reply to topics in this forum